-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update loading skeletons #4982
Update loading skeletons #4982
Conversation
Full-stack documentation: https://docs.openverse.org/_preview/4982 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
faec2d9
to
67f3beb
Compare
6b6d5ec
to
97673c8
Compare
Latest k6 run output1
Footnotes
|
97673c8
to
17141c9
Compare
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @zackkrida Excluding weekend1 days, this PR was ready for review 8 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great 🚀
645bdc2
to
cf682be
Compare
cf682be
to
2f7bd19
Compare
Fixes
Fixes #4829 by @fcoveram
Description
This PR updates the skeleton colors to match the updated designs.
It also fixes the number of columns when the sidebar is visible: the
isSidebarVisible
prop wasn't passed, so the number of columns was set the same when the sidebar was open, and the screen was narrower, as when it was closed.It also moves some styles to Tailwind classes, and simplifies the Storybook story.
Testing Instructions
Open the browser devtools and set slower speed in the "Network" tab's throttling settings.
Try searching for something in Openverse. Use some new search terms to prevent loading from cache. You should see loading skeletons. The number of columns in "All content" view should match the number of columns in the results when the filters sidebar is open (In staging, you can see that there are more columns of the skeleton than of the search results when the sidebar is open)
Check the loading skeletons in Storybook, in both dark and light modes.
Emulate
prefers reduced motion
using the browser devtools, and see that the skeletons are not animated.Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin